Feat/sip 031 boot contract #6261
Open
+219
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ip_031_boot_contract
|
@rdeioris I merged in the release branch just have this branch's diff (which I'm also building on top of) more clean, hope you don't mind! |
|
@hstove added a bunch of checks for the mint receipt in the integration test. Please re-review. thanks! |
hstove
approved these changes
Jul 16, 2025
kantai
reviewed
Jul 16, 2025
|
|
||
| let mut sip_031_initialization_receipt = self.as_transaction(|tx_conn| { | ||
| // initialize with a synthetic transaction | ||
| debug!("Instantiate {} contract", &sip_031_contract_id); |
There was a problem hiding this comment.
Might as well make this info! -- we only expect this to happen the one time.
| ASTRules::PrecheckSize, | ||
| None, | ||
| ) | ||
| .expect("FATAL: Failed to process .sip031 contract initialization"); |
There was a problem hiding this comment.
Suggested change
| .expect("FATAL: Failed to process .sip031 contract initialization"); | |
| .expect("FATAL: Failed to process .sip-031 contract initialization"); |
| }; | ||
|
|
||
| let boot_code_address = boot_code_addr(mainnet); | ||
| let boot_code_auth = boot_code_tx_auth(boot_code_address.clone()); |
There was a problem hiding this comment.
Suggested change
| let boot_code_auth = boot_code_tx_auth(boot_code_address.clone()); | |
| let boot_code_auth = boot_code_tx_auth(boot_code_address); |
| ); | ||
| } | ||
|
|
||
| let recipient = PrincipalData::Contract(boot_code_id(SIP_031_NAME, mainnet)); |
There was a problem hiding this comment.
Suggested change
| let recipient = PrincipalData::Contract(boot_code_id(SIP_031_NAME, mainnet)); | |
| let recipient = PrincipalData::Contract(sip_031_contract_id); |
| @@ -12756,6 +12760,121 @@ fn test_sip_031_activation() { | |||
|
|
|||
| assert_eq!(epoch_version, Some(StacksEpochId::Epoch32)); | |||
|
|
|||
| // check if sip-031 boot contract has been deployed | |||
There was a problem hiding this comment.
Can you also add a check that the liquid ustx supply has incremented correctly?
obycode
reviewed
Jul 16, 2025
| @@ -12635,7 +12639,7 @@ fn write_signer_update( | |||
| /// Test SIP-031 activation | |||
| /// | |||
| /// - check epoch 3.2 is active | |||
| /// - TODO: check sip031 boot contract has a balance of 200_000_000 STX (TODO) | |||
| /// - check sip031 boot contract has a balance of 200_000_000 STX (TODO) | |||
There was a problem hiding this comment.
Suggested change
| /// - check sip031 boot contract has a balance of 200_000_000 STX (TODO) | |
| /// - check sip031 boot contract has a balance of 200_000_000 STX |
| .unwrap() | ||
| .as_str() | ||
| .unwrap(), | ||
| "200000000000000" |
There was a problem hiding this comment.
Suggested change
| "200000000000000" | |
| SIP_031_INITIAL_MINT.to_string(), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the boot-contract and management for SIP-031 initial mint and assignment.
During the epoch-32 activation, 200_000_000 STX are minted and trasferred to the contract.
The contract is still a stub
Applicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/rpc/openapi.yamlandrpc-endpoints.mdfor v2 endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepobitcoin-tests.yml